fix(delegation): honor direct endpoint api_key_env#48579
Open
Veritas-7 wants to merge 2 commits into
Open
Conversation
Use delegation.api_key_env when resolving direct endpoint credentials so custom delegation endpoints can receive their provider-specific key instead of inheriting an unrelated parent key. Add regression coverage for a custom direct endpoint using GLM_API_KEY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delegation.api_key_envfor direct delegation endpoints before falling back to parent credential inheritance.ValueErrorwhen the configured env var is missing or empty.check-attributionworkflow for this PR author email.Problem
Direct delegation endpoints can point at providers whose key lives outside the parent agent's API key. If
delegation.api_key_envis configured but not resolved, the child can inherit an unrelated parent key and fail authentication against the direct endpoint.Tests
git diff --check origin/main...HEADpython3 -m py_compile tools/delegate_tool.py scripts/release.pypython3 -m pytest tests/tools/test_delegate.py::TestDelegationCredentialResolution -q -o 'addopts='→ 19 passedcheck-attributionemail mapping → passgitleaks detect --source . --no-banner --redact --log-opts='origin/main..HEAD'→ no leaks foundNote: full
tests/tools/test_delegate.pycurrently has an unrelated heartbeat test failure onorigin/main; this PR's focused credential suite passes.